Empty lines above <doctype> in source code

(Charlotte Westney) #1

Hi everyone,


Not a major problem, just something that's annoying me:



All my sites use EES, and code for the EES goes at the top of the Design parse file, followed by the code for the site, which starts with <Doctype… />



I've removed all the whitespace from this part of the parse file, but my <Doctype /> tag still appears on line 2 of the html source code. Is there a way to get the <Doctype /> tag to start on line 1?



Thanks,

Charlie.

(Edison Wang) #2

Show if design area always prints a blank line before its content. I fixed it as a bug.
http://bugs.matrix.squiz.net/view_bug.php?bug_id=5793



CVS link:

http://public-cvs.squiz.net/cgi-bin/viewvc.cgi/mysource_matrix/core/assets/designs/design_areas/design_area_show_if/design_area_show_if.inc?root=matrix_core&r1=1.14&r2=1.14.22.1



Patch it and re-commit the design, the blank line will be gone.



If you can't patch it, you can just take out all the spaces between the content and <MySource_THEN> tag. It should do the trick too.

(Tom Chadwin) #3

I still can't get rid of the white space above the doctype in 4.14.3. I've put all of the EES code onto one line with the public-facing doctype, but I still get two tabs appearing on the line before it. Parsefile:

 

<MySource_AREA id_name="exit_area" design_area="exit" print="no"></MySource_AREA><MySource_AREA id_name="nested_EES_code" design_area="nest_content" print="no" /><MySource_AREA id_name="simple_edit_EES" design_area="show_if"><MySource_SET name="condition" value="simple_edit_mode" /><MySource_THEN><!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8" /><title>Loading Easy Edit Suite...</title><MySource_PRINT id_name="nested_EES_code" /></head><body></body></html><MySource_PRINT id_name="exit_area" /></MySource_THEN></MySource_AREA><!DOCTYPE html>
 
Output:
 
  <!DOCTYPE html>
<html class="no-js no-touch">
 
Is this fixable in this Matrix version?
 
Thanks
 
Tom
(Chiranjivi Upreti) #4

 

I still can't get rid of the white space above the doctype in 4.14.3. I've put all of the EES code onto one line with the public-facing doctype, but I still get two tabs appearing on the line before it. Parsefile:

 

<MySource_AREA id_name="exit_area" design_area="exit" print="no"></MySource_AREA><MySource_AREA id_name="nested_EES_code" design_area="nest_content" print="no" /><MySource_AREA id_name="simple_edit_EES" design_area="show_if"><MySource_SET name="condition" value="simple_edit_mode" /><MySource_THEN><!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8" /><title>Loading Easy Edit Suite...</title><MySource_PRINT id_name="nested_EES_code" /></head><body></body></html><MySource_PRINT id_name="exit_area" /></MySource_THEN></MySource_AREA><!DOCTYPE html>
 
Output:
 
  <!DOCTYPE html>
<html class="no-js no-touch">

 

This has been already fixed in bug #6714 in versions > 4.16.5 and 4.18.1.

(Tom Chadwin) #5

Ah, OK. Thanks. I’ve since worked out that my problems were not being caused by this anyway, so I can wait until our upgrade.